Skip to content

fix(Banner): stack inline actions vertically on narrow viewports #7625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liuliu-dev wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(Banner): stack inline actions vertically on narrow viewports #7625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
234434d
column-reverse on narrow
liuliu-dev Mar 4, 2026
047bfd6
chore: auto-fix lint and formatting issues
liuliu-dev Mar 4, 2026
cc204e5
column
liuliu-dev Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gold-rooms-bake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Banner: stack inline actions vertically on narrow viewports.
4 changes: 4 additions & 0 deletions packages/react/src/Banner/Banner.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@

& .BannerActions :where([data-primary-action='trailing']) {
display: flex;

@media screen and (--viewportRange-narrow) {
flex-direction: column;
}
Comment on lines +44 to +46
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes a narrow-viewport layout issue, but the existing Banner stories don’t currently cover actionsLayout="inline" at ~320px with both primary and secondary actions (the mobile example only shows a primary action). Adding/updating a Storybook case (and corresponding VRT/AVT coverage if applicable) for inline+two-actions at narrow widths would help prevent regressions.

Copilot uses AI. Check for mistakes.
}

& .BannerActions :where([data-primary-action='leading']) {
Expand Down
Loading