Add parsing related unit tests for JSONArray#1484
Open
satindra-r wants to merge 1 commit intoprocessing:mainfrom
Open
Add parsing related unit tests for JSONArray#1484satindra-r wants to merge 1 commit intoprocessing:mainfrom
satindra-r wants to merge 1 commit intoprocessing:mainfrom
Conversation
catilac
requested changes
Mar 18, 2026
Collaborator
catilac
left a comment
catilac
left a comment
There was a problem hiding this comment.
lgtm, i've added a comment about some stylistic changes!
Comment on lines
+193
to
+196
| String json = "[\n" + | ||
| "null,\n" + | ||
| "null\n" + | ||
| "]"; |
Collaborator
There was a problem hiding this comment.
why not just make this one string instead of multiple addition operations?
Comment on lines
+204
to
+207
| String json = "[\n" + | ||
| "1,\n" + | ||
| "2\n" + | ||
| "]"; |
Collaborator
There was a problem hiding this comment.
same as above, this only makes things more difficult to read
Collaborator
|
@satindra-r thank you so much! i've left some feedback, and i'm triggering the tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests to the
JSONArrayclass in core which has some fragile parsing logic.Solves #1470