Skip to content

Add signing-service as an argument to repository creation and updation #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
balasankarc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add signing-service as an argument to repository creation and updation #227

balasankarc wants to merge 1 commit into from

Conversation

@balasankarc
Copy link

@balasankarc balasankarc commented Oct 19, 2025 •
edited
Loading

Closes to #54

Implements --signing-service argument to pulp deb repository create command.

@balasankarc
Copy link
Author

balasankarc commented Oct 19, 2025

@quba42 @bmbouter I am not exactly sure how to handle signing_service_release_overrides that was added in pulp/pulp_deb#689, which takes in a dictionary as input. Do you have any suggestions, or does the project have any precedents?

@balasankarc
Copy link
Author

balasankarc commented Oct 19, 2025 •
edited
Loading

@quba42 @bmbouter I am not exactly sure how to handle signing_service_release_overrides that was added in pulp/pulp_deb#689, which takes in a dictionary as input. Do you have any suggestions, or does the project have any precedents?

4593c2c is my way of implementing it. WDYT?

@balasankarc balasankarc force-pushed the add-signing-service-repository branch 2 times, most recently from 4593c2c to 3596388 Compare October 20, 2025 14:55
@quba42 quba42 mentioned this pull request Oct 27, 2025
Merged
@balasankarc balasankarc force-pushed the add-signing-service-repository branch 3 times, most recently from 1042978 to 7c71bd3 Compare November 14, 2025 13:44
@balasankarc balasankarc force-pushed the add-signing-service-repository branch from 7c71bd3 to 10a1995 Compare January 21, 2026 08:44
@github-actions github-actions bot removed the no-issue label Jan 21, 2026
@balasankarc balasankarc force-pushed the add-signing-service-repository branch from 10a1995 to 06b6653 Compare January 21, 2026 08:45
@balasankarc balasankarc changed the title Add signing-service as an argument to repository creation Add signing-service as an argument to repository creation and updation Jan 21, 2026
@balasankarc
Copy link
Author

balasankarc commented Jan 21, 2026

@quba42 Can you take a look? Thanks.

@mdellweg
Copy link
Member

mdellweg commented Jan 21, 2026

It might help to add some testing to see that it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@balasankarc @mdellweg