Remove build_plan from lockfile to improve perf#1362
Merged
Conversation
Member
|
This is a breaking change, in that |
Member
|
Code looks good, though 👍 |
fsoikin
reviewed
Jan 21, 2026
Collaborator
fsoikin
left a comment
There was a problem hiding this comment.
There is also a comment that refers to storing all transitive dependencies in the lockfile:
spago/src/Spago/Command/Fetch.purs
Lines 162 to 164 in 782311b
I also noticed that there is a copy&paste of computing transitive deps for all workspace packages - here and here. Perhaps these should be consolidated?
Co-authored-by: Fyodor Soikin <name.fa@gmail.com>
fsoikin
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1262 by following the approach I explained at the time - we remove
build_planfrom each package of the lockfile since it's faster to recompute it than to decode it, as the files can get massive.cc @finnhodgkin