Skip to content

fix: themed color for icons#275

Closed
brisvag wants to merge 2 commits intopyapp-kit:mainfrom
brisvag:feature/color-icon
Closed

fix: themed color for icons#275
brisvag wants to merge 2 commits intopyapp-kit:mainfrom
brisvag:feature/color-icon

Conversation

@brisvag
Copy link

@brisvag brisvag commented Feb 19, 2026

When icons are provided via fonticons or iconify, theme is currently disergarded. Defaulting to black/white should be at least a tiny bit nicer than just black!

@brisvag brisvag changed the title Add themed color for icons fix: themed color for icons Feb 19, 2026
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.62%. Comparing base (7f1e493) to head (6d96845).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files          31       31           
  Lines        1878     1879    +1     
=======================================
+ Hits         1871     1872    +1     
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brisvag
Copy link
Author

brisvag commented Feb 19, 2026

Mmm, just realized the theme is not passed through at all 🤔

@tlambert03
Copy link
Member

see also #132 which was trying to improve icon color support. let me know what overlaps

@brisvag
Copy link
Author

brisvag commented Feb 19, 2026

Ah, silly me, I didn't check before opening. It's definitely covered there, sorry for the noise!

@brisvag brisvag closed this Feb 19, 2026
@tlambert03
Copy link
Member

well, it's not noise! Cause that PR is two years old with no activity 😂 it would be awesome, if this is something you're wanting to see changed, for you to take it over the finish line. i can't remember anymore any of the details... but feel free to go any direction you want with it

@tlambert03
Copy link
Member

it's also fine if the scope of that PR makes too big what was just a simple fix and you want this in instead

@brisvag
Copy link
Author

brisvag commented Feb 19, 2026

Yeah I might try to take it up soon, we'll see if I can figure it out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants