Allow writing StringDType variables to netCDF#11218
Open
kkollsga wants to merge 2 commits intopydata:mainfrom
Open
Allow writing StringDType variables to netCDF#11218kkollsga wants to merge 2 commits intopydata:mainfrom
kkollsga wants to merge 2 commits intopydata:mainfrom
Conversation
Recognize numpy.dtypes.StringDType (kind "T") as a unicode string type in is_unicode_dtype, and convert StringDType arrays to object arrays before passing to netCDF4/h5netcdf backends which don't support StringDType natively. Null values from StringDType(na_object=None) are replaced with empty strings on write. Co-authored-by: Claude <noreply@anthropic.com>
5 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numpy.dtypes.StringDType(kind"T") as a unicode string type inis_unicode_dtype, so the encoding pipeline and backend dtype selection handle it correctly.netCDF4andh5netcdfbackendprepare_variablemethods, since neither C library supports StringDType natively.StringDType(na_object=None)are replaced with empty strings on write, matching existing behavior for object-dtype string arrays with missing values.EncodedStringCoder(allows_unicode=False)encodes strings to bytes viaencode_string_array, which handles StringDType.Test plan
test_is_unicode_dtype_stringdtype— unit test foris_unicode_dtypewith StringDTypetest_roundtrip_stringdtype_data— roundtrip test inDatasetIOBase, runs across all backends (netCDF4, h5netcdf, scipy, zarr)StringDType(na_object=None)🤖 Generated with Claude Code