Add version support to workspace/publishDiagnostics#565
Merged
ccordoba12 merged 4 commits intopython-lsp:developfrom Jul 24, 2024
Merged
Add version support to workspace/publishDiagnostics#565ccordoba12 merged 4 commits intopython-lsp:developfrom
workspace/publishDiagnostics#565ccordoba12 merged 4 commits intopython-lsp:developfrom
Conversation
Contributor
Author
|
There is a versionSupport capability passed by the client which we could check beforehand but the field is optional and we already track the document version so I don't believe there is much reason to change behaviour based on it |
ccordoba12
reviewed
Jun 6, 2024
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks for your contribution @Dylmay!
Contributor
Author
|
@ccordoba12, could I have a re-review please |
Member
|
Closing and reopening to run our tests again. |
ccordoba12
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we do not pass version information when we are publishing diagnostics. See: LSP protocol
Now we pass the version information so the client can create an opinion as to whether the current diagnostics are valid or not for the workspace