Move verbose and coverage options for pytest back to ci script#78
Move verbose and coverage options for pytest back to ci script#78vxgmichel wants to merge 2 commits intopython-trio:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 16 16
Lines 574 574
=======================================
Hits 524 524
Misses 50 50 |
altendky
left a comment
There was a problem hiding this comment.
I am fine, maybe even prefer, for this PR to stay focused on what it is now but will note that it might be worth a full catch up with https://github.com/python-trio/trio itself for the CI setup. Cookie cutter... does a thing but leaves us finding and fixing bugs repeatedly in the various projects.
| @@ -1,2 +1,2 @@ | |||
| [pytest] | |||
| addopts = -W error -ra -v --pyargs pytest_trio --verbose --cov | |||
| addopts = -W error --pyargs pytest_trio | |||
There was a problem hiding this comment.
I would personally like to see the --pyargs pytest_trio go away too as it keeps me from running individual tests such as when trying to debug with breakpoints in PyCharm. At which point we are left with -W error and could just move everything to CI and drop this file. I think this is where https://github.com/python-trio/trio/ itself is at.
For that matter, the --cov (that you already moved) broke breakpoints entirely in PyCharm too.
ci/travis.sh
Outdated
| cd empty | ||
|
|
||
| pytest | ||
| pytest -r a --verbose --cov --cov-config=../.coveragerc |
There was a problem hiding this comment.
| pytest -r a --verbose --cov --cov-config=../.coveragerc | |
| # We have to copy .coveragerc into this directory, rather than passing | |
| # --cov-config=../.coveragerc to pytest, because codecov.sh will run | |
| # 'coverage xml' to generate the report that it uses, and that will only | |
| # apply the ignore patterns in the current directory's .coveragerc. | |
| cp ../.coveragerc . | |
| pytest -r a --verbose --cov |
python-trio/trio@02066df
altendky/qtrio@f9d2d1c
Though I'll note that I would personally rather just have a src/ directory rather than creating empty/ and copying all the config files around. python-trio/trio#274 has some related commentary against src/.
|
Rebased on top of master to get GitHub Actions CI. |
|
Fixed merge conflicts |
Address the point made in this comment by @njsmith (PR #76):