gh-109861: Fix a doctest in Lib/_pydecimal.py which was failing when running its doctests directly.
#125479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directly on the module via the command: ``./python.exe -m doctest Lib/_pydecimal.py``. Co-authored-by: Sergey B Kirpichev <[email protected]>
skirpichev
requested changes
Oct 15, 2024
Member
skirpichev
left a comment
skirpichev
left a comment
There was a problem hiding this comment.
I think we should stick with your solution for _pydecimal.py. It's more local.
require the ``InvalidOperation`` trap to be ``False``.
skirpichev
approved these changes
Oct 15, 2024
Member
|
CC @picnixz |
skirpichev
added
needs backport to 3.13
picnixz
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-109861: Fix a doctest in
Lib/_pydecimal.pywhich was failing when run directly on the module via the command:./python.exe -m doctest Lib/_pydecimal.py.