gh-144194: Fix mmap failure check in perf_jit_trampoline.c #143713
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi, I think a related issue and a news entry file are needed for this PR. Please read the Dev Guide (especially https://devguide.python.org/getting-started/pull-request-lifecycle/) to see what is required when creating a PR. |
vstinner
added
needs backport to 3.13
stratakis
changed the title
Misc/NEWS.d/next/Core_and_Builtins/2026-01-23-20-20-42.gh-issue-144194.IbXfxd.rst
Outdated
Show resolved
Hide resolved
Member
|
You need to update your branch to fix the CI, it is incompatible. |
vstinner
approved these changes
Jan 26, 2026
vstinner
reviewed
Jan 28, 2026
Misc/NEWS.d/next/Core_and_Builtins/2026-01-23-20-20-42.gh-issue-144194.IbXfxd.rst
Outdated
Show resolved
Hide resolved
mmap() returns MAP_FAILED ((void*)-1) on error, not NULL. The current check never detects mmap failures, so jitdump initialization proceeds even when the memory mapping fails.
Member
|
Thanks for fixing the Linter issue ;-) |
|
Thanks @stratakis for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 28, 2026
…honGH-143713) mmap() returns MAP_FAILED ((void*)-1) on error, not NULL. The current check never detects mmap failures, so jitdump initialization proceeds even when the memory mapping fails. (cherry picked from commit 8fe8a94) Co-authored-by: stratakis <[email protected]>
|
Sorry, @stratakis and @vstinner, I could not cleanly backport this to |
|
GH-144301 is a backport of this pull request to the 3.14 branch. |
|
GH-144304 is a backport of this pull request to the 3.13 branch. |
Member
|
PR merged, thanks for the fix. |
vstinner
pushed a commit
that referenced
this pull request
Jan 28, 2026
…-143713) (#144301) gh-144194: Fix mmap failure check in perf_jit_trampoline.c (GH-143713) mmap() returns MAP_FAILED ((void*)-1) on error, not NULL. The current check never detects mmap failures, so jitdump initialization proceeds even when the memory mapping fails. (cherry picked from commit 8fe8a94) Co-authored-by: stratakis <[email protected]>
vstinner
added a commit
that referenced
this pull request
Jan 28, 2026
…43713) (#144304) gh-144194: Fix mmap failure check in perf_jit_trampoline.c (#143713) mmap() returns MAP_FAILED ((void*)-1) on error, not NULL. The current check never detects mmap failures, so jitdump initialization proceeds even when the memory mapping fails. (cherry picked from commit 8fe8a94) Co-authored-by: stratakis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mmap() returns MAP_FAILED ((void*)-1) on error, not NULL. The current check never detects mmap failures, so jitdump initialization proceeds even when the memory mapping fails.