gh-145779: Improve classmethod/staticmethod scaling in free-threaded build#145826
Open
colesbury wants to merge 1 commit intopython:mainfrom
Open
gh-145779: Improve classmethod/staticmethod scaling in free-threaded build#145826colesbury wants to merge 1 commit intopython:mainfrom
colesbury wants to merge 1 commit intopython:mainfrom
Conversation
…eaded build Add special cases for classmethod and staticmethod descriptors in _PyObject_GetMethodStackRef() to avoid calling tp_descr_get, which avoids reference count contention on the bound method and underlying callable. This improves scaling when calling classmethods and staticmethods from multiple threads. Refactor method_vectorcall in classobject.c into a new _PyObject_VectorcallPrepend() helper so that it can be used by by PyObject_VectorcallMethod as well.
colesbury
force-pushed
the
gh-145779-classmethod-staticmethod-scaling
branch
from
70b0a53 to
d86950f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add special cases for classmethod and staticmethod descriptors in
_PyObject_GetMethodStackRef()to avoid callingtp_descr_get, which avoids reference count contention on the bound method and underlying callable. This improves scaling when calling classmethods and staticmethods from multiple threads.Also refactor method_vectorcall in classobject.c into a new
_PyObject_VectorcallPrepend()helper so that it can be used byPyObject_VectorcallMethodas well.@classmethodand@staticmethod#145779