Skip to content

Conversation

@kirklandsign
Copy link
Contributor

Summary

Add option to disable ARM SME2 for Android emulator compatibility, which may crash when SME2 kernels are used.

Test plan

CI

Add option to disable ARM SME2 for Android emulator compatibility,
which may crash when SME2 kernels are used.
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 14, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16589

Note: Links to docs will display an error until the docs builds have been completed.

❌ 24 New Failures, 4 Unrelated Failures

As of commit 3580356 with merge base f39016d (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 14, 2026
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign kirklandsign marked this pull request as ready for review January 20, 2026 08:05
Copilot AI review requested due to automatic review settings January 20, 2026 08:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for disabling ARM SME2 instructions in the Android release workflow to ensure compatibility with Android emulators that may crash when SME2 kernels are used.

Changes:

  • Added a new "xnnpack-no-sme2" flavor option to the Android release workflow
  • Introduced the XNNPACK_ENABLE_ARM_SME2 configuration flag (defaulting to ON) that can be overridden
  • Added documentation explaining when and why to disable SME2

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/android-release-artifacts.yml Added "xnnpack-no-sme2" flavor option and conditional logic to disable SME2 when this flavor is selected
scripts/build_android_library.sh Added XNNPACK_ENABLE_ARM_SME2 environment variable (defaulting to ON) and passed it to CMake configuration
backends/xnnpack/cmake/Dependencies.cmake Added documentation comments explaining the ARM SME2 flag and when it should be disabled

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@GregoryComer GregoryComer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's odd that it's crashing on emulator. I can try to take a look and we can fix the underlying issue, but I'm fine to just disable it for now.

@kirklandsign
Copy link
Contributor Author

It's odd that it's crashing on emulator. I can try to take a look and we can fix the underlying issue, but I'm fine to just disable it for now.

GPT says something to do with emulator support on Apple Silicon.

@kirklandsign kirklandsign merged commit 3c1500c into main Jan 20, 2026
135 of 163 checks passed
@kirklandsign kirklandsign deleted the no-sme-build branch January 20, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants