-
Notifications
You must be signed in to change notification settings - Fork 822
Add xnnpack-no-sme2 flavor to Android release workflow #16589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add option to disable ARM SME2 for Android emulator compatibility, which may crash when SME2 kernels are used.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16589
Note: Links to docs will display an error until the docs builds have been completed. ❌ 24 New Failures, 4 Unrelated FailuresAs of commit 3580356 with merge base f39016d ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds support for disabling ARM SME2 instructions in the Android release workflow to ensure compatibility with Android emulators that may crash when SME2 kernels are used.
Changes:
- Added a new "xnnpack-no-sme2" flavor option to the Android release workflow
- Introduced the
XNNPACK_ENABLE_ARM_SME2configuration flag (defaulting to ON) that can be overridden - Added documentation explaining when and why to disable SME2
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/android-release-artifacts.yml |
Added "xnnpack-no-sme2" flavor option and conditional logic to disable SME2 when this flavor is selected |
scripts/build_android_library.sh |
Added XNNPACK_ENABLE_ARM_SME2 environment variable (defaulting to ON) and passed it to CMake configuration |
backends/xnnpack/cmake/Dependencies.cmake |
Added documentation comments explaining the ARM SME2 flag and when it should be disabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GregoryComer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's odd that it's crashing on emulator. I can try to take a look and we can fix the underlying issue, but I'm fine to just disable it for now.
GPT says something to do with emulator support on Apple Silicon. |
Summary
Add option to disable ARM SME2 for Android emulator compatibility, which may crash when SME2 kernels are used.
Test plan
CI