Skip to content

Conversation

@mgiordy
Copy link
Contributor

@mgiordy mgiordy commented Jan 14, 2026

Summary:

Summary

This diff fixes the Conv1d w8a32 operator by adding a transformation to the val attribute of the other_inputs[0].meta dictionary. Specifically, the permute operation is applied to the original_val tensor with the fake_mode context, and the resulting transposed_val is assigned to transposed_inputs.meta["val"].

Reviewed By: mcremon-meta

Differential Revision: D89863750

Summary:
#### Summary

This diff fixes the Conv1d w8a32 operator by adding a transformation to the `val` attribute of the `other_inputs[0].meta` dictionary. Specifically, the `permute` operation is applied to the `original_val` tensor with the `fake_mode` context, and the resulting `transposed_val` is assigned to `transposed_inputs.meta["val"]`.

Reviewed By: mcremon-meta

Differential Revision: D89863750
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 14, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16607

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 727b730 with merge base 9cbe754 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 14, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Jan 14, 2026

@mgiordy has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89863750.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant