Skip to content

Add json header to buck needed for CoreML multifunction passed metadata parsing #16634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
derekxu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add json header to buck needed for CoreML multifunction passed metadata parsing #16634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bff3719
Scott's changes for rebasing: D90716824
Jan 15, 2026
66d4f22
Add json header to buck needed for CoreML multifunction passed metada…
Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions backends/apple/coreml/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ runtime.cxx_library(
"-Wno-receiver-expr",
"-Wno-error",
],
preprocessor_flags = [
"-DJSON_NOEXCEPTION",
],
define_static_target = True,
header_namespace = "backends/apple/coreml",
exported_headers = ["runtime/delegate/executorch_operations.h", "runtime/include/coreml_backend/delegate.h"],
Expand All @@ -89,6 +92,7 @@ runtime.cxx_library(
platforms = [APPLE],
visibility = ["PUBLIC"],
deps = [
"fbsource//third-party/nlohmann-json:nlohmann-json",
"//executorch/runtime/backend:interface",
"//executorch/runtime/core:core",
"//executorch/runtime/kernel:kernel_includes",
Expand Down
8 changes: 8 additions & 0 deletions backends/apple/coreml/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,14 @@ if(APPLE)
target_link_libraries(coremldelegate PRIVATE libprotobuf-lite)
endif()

# Add nlohmann_json include directory (header-only library) Define
# JSON_NOEXCEPTION since coremldelegate is compiled with -fno-exceptions
target_include_directories(
coremldelegate
PRIVATE ${PROJECT_SOURCE_DIR}/third-party/json/single_include
)
target_compile_definitions(coremldelegate PRIVATE JSON_NOEXCEPTION)

target_link_libraries(
coremldelegate
PUBLIC coreml_util coreml_inmemoryfs
Expand Down
Loading
Loading