Skip to content

Conversation

@Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Jan 16, 2026

.graph_module doesn't work for models with weights. Also set check_guards=False, guards don't work well with et. This is addressed in et in a rather hacky way, see https://github.com/pytorch/pytorch/blob/19d8ad08cd8c6ee15c34117daaaea04d929778e4/torch/export/_unlift.py#L734

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

.graph_module doesn't work for models with weights.
Also set check_guards=False, guards don't work well with et.
This is addressed in et in a rather hacky way, see
https://github.com/pytorch/pytorch/blob/19d8ad08cd8c6ee15c34117daaaea04d929778e4/torch/export/_unlift.py#L734

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: I07182d25e4828195707bdf173d1bb2b1f98ebe6c
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 16, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16645

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit 4846f65 with merge base a0ba28e (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2026
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 16, 2026
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2026
Copy link
Collaborator

@zingo zingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge!

@Erik-Lundell Erik-Lundell merged commit 255d4f9 into pytorch:main Jan 16, 2026
296 of 314 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants