Skip to content

Fix lint in Vulkan backend#18081

Merged
manuelcandales merged 1 commit intomainfrom
manuel/fix-lint-vulkan
Mar 10, 2026
Merged

Fix lint in Vulkan backend#18081
manuelcandales merged 1 commit intomainfrom
manuel/fix-lint-vulkan

Conversation

@manuelcandales
Copy link
Contributor

@manuelcandales manuelcandales commented Mar 10, 2026

Forward fixing lint for #18031

cc @SS-JIA @digantdesai @cbilgin

@manuelcandales manuelcandales requested a review from SS-JIA as a code owner March 10, 2026 23:44
Copilot AI review requested due to automatic review settings March 10, 2026 23:44
@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Mar 10, 2026
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 10, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18081

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 Cancelled Jobs, 44 Pending

As of commit 65b2fc2 with merge base 918e92b (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 10, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR forward-fixes a lint/formatting issue in the Vulkan backend’s quantized convolution pattern matcher, aligning formatting with the repository’s Python style tooling.

Changes:

  • Reformats the output_padding assignment in QuantizedConvolutionMatch.__init__ to satisfy lint/line-length formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@manuelcandales manuelcandales force-pushed the manuel/fix-lint-vulkan branch from 3d84f57 to 65b2fc2 Compare March 10, 2026 23:48
@manuelcandales manuelcandales added the release notes: none Do not include this in the release notes label Mar 10, 2026
@manuelcandales manuelcandales merged commit 103deb6 into main Mar 10, 2026
147 of 156 checks passed
@manuelcandales manuelcandales deleted the manuel/fix-lint-vulkan branch March 10, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants