Skip to content

Windows schannel fix#18137

Merged
manuelcandales merged 1 commit intomainfrom
schannel_ethos_fix
Mar 13, 2026
Merged

Windows schannel fix#18137
manuelcandales merged 1 commit intomainfrom
schannel_ethos_fix

Conversation

@digantdesai
Copy link
Contributor

@digantdesai digantdesai commented Mar 12, 2026 •
edited
Loading

Fix for windows build failures,

Error: fatal: unable to access 'https://git.gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-core-driver.git/': schannel: next InitializeSecurityContext failed: SEC_E_ILLEGAL_MESSAGE (0x80090326) - This error usually occurs when a fatal SSL/TLS alert is received (e.g. handshake failed). More detail may be available in the Windows System event log.

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 12, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18137

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 169 Pending

As of commit d794091 with merge base 96aeb57 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2026
@github-actions
Copy link

github-actions bot commented Mar 12, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@digantdesai digantdesai marked this pull request as ready for review March 13, 2026 04:03
Copilot AI review requested due to automatic review settings March 13, 2026 04:03
Copilot AI reviewed Mar 13, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Windows CI workflows to avoid Git’s Schannel TLS backend issues by switching Git to the OpenSSL backend before initializing submodules, ensuring submodule checkout succeeds on affected Windows runners.

Changes:

  • Stop relying on the reusable windows_job.yml workflow’s submodules: recursive option for Windows jobs.
  • Add git config --global http.sslBackend openssl followed by git submodule update --init --recursive at the start of affected Windows job scripts.
  • Apply the same pattern across key Windows workflows (MSVC build, trunk Windows model tests, CUDA Windows E2E, build presets, and Windows unittest job).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/windows-msvc.yml Configures Git SSL backend and manually initializes submodules before MSVC build setup.
.github/workflows/trunk.yml Same Git SSL/submodule init adjustment for the Windows models test job.
.github/workflows/cuda-windows.yml Same Git SSL/submodule init adjustment for CUDA Windows E2E job.
.github/workflows/build-presets.yml Same Git SSL/submodule init adjustment for Windows preset builds.
.github/workflows/_unittest.yml Same Git SSL/submodule init adjustment for Windows unittests job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@digantdesai
Fix Windows CI schannel error for all windows jobs
d794091 
This is a temp fix.

Ask git to not use schannel and do
`git submodule update --init --recursive` manually in the job.
@digantdesai digantdesai added the module: ci Issues related to continuous integration label Mar 13, 2026
@manuelcandales manuelcandales changed the title Test windows schannel fix Windows schannel fix Mar 13, 2026
@manuelcandales manuelcandales merged commit 0c28e7b into main Mar 13, 2026
198 of 207 checks passed
@manuelcandales manuelcandales deleted the schannel_ethos_fix branch March 13, 2026 15:39
@manuelcandales
Copy link
Contributor

manuelcandales commented Mar 13, 2026

@pytorchbot cherry-pick --onto release/1.2 -c critical

pytorchbot pushed a commit that referenced this pull request Mar 13, 2026
@digantdesai @pytorchbot
Windows schannel fix (#18137)
ee9d522 
Fix for windows build failures,

```
Error: fatal: unable to access 'https://git.gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-core-driver.git/': schannel: next InitializeSecurityContext failed: SEC_E_ILLEGAL_MESSAGE (0x80090326) - This error usually occurs when a fatal SSL/TLS alert is received (e.g. handshake failed). More detail may be available in the Windows System event log.
```

(cherry picked from commit 0c28e7b)
@pytorchbot
Copy link
Collaborator

pytorchbot commented Mar 13, 2026

Cherry picking #18137

The cherry pick PR is at #18157 and it is recommended to link a critical cherry pick PR with an issue.

Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@manuelcandales manuelcandales manuelcandales approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: ci Issues related to continuous integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@digantdesai @manuelcandales @pytorchbot