Skip to content

fix binary size test#18177

Closed
lucylq wants to merge 1 commit intomainfrom
lfq.fix-binary-size-test
Closed

fix binary size test#18177
lucylq wants to merge 1 commit intomainfrom
lfq.fix-binary-size-test

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Mar 13, 2026

Summary

fix gcc binary test

broken after: #18142

Test plan

ci

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 13, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18177

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 42 Pending

As of commit 6a315cc with merge base 4f900b2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2026
@lucylq lucylq marked this pull request as ready for review March 13, 2026 22:56
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@lucylq lucylq force-pushed the lfq.fix-binary-size-test branch from 0ca4928 to 6a315cc Compare March 13, 2026 22:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes GCC build failures introduced after #18142 by making bounds checks compare like-signed integer types in portable CPU kernels (avoids -Wsign-compare under -Werror, which impacts the binary size test build).

Changes:

  • Cast in_W/in_H/out_W/out_H (stored as size_t) to ssize_t in bounds checks against computed ssize_t indices.
  • Applies the same fix pattern in both the generic kernel util path and the convolution implementation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
kernels/portable/cpu/util/kernel_ops_util.h Fixes signed/unsigned comparison in 2D kernel bounds checks (in_x/in_y vs in_W/in_H).
kernels/portable/cpu/op_convolution.cpp Fixes signed/unsigned comparison in conv2d (and transposed conv) bounds checks for input/output coordinates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@lucylq lucylq closed this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants