Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18177
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 42 PendingAs of commit 6a315cc with merge base 4f900b2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
0ca4928 to
6a315cc
Compare
There was a problem hiding this comment.
Pull request overview
Fixes GCC build failures introduced after #18142 by making bounds checks compare like-signed integer types in portable CPU kernels (avoids -Wsign-compare under -Werror, which impacts the binary size test build).
Changes:
- Cast
in_W/in_H/out_W/out_H(stored assize_t) tossize_tin bounds checks against computedssize_tindices. - Applies the same fix pattern in both the generic kernel util path and the convolution implementation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
kernels/portable/cpu/util/kernel_ops_util.h |
Fixes signed/unsigned comparison in 2D kernel bounds checks (in_x/in_y vs in_W/in_H). |
kernels/portable/cpu/op_convolution.cpp |
Fixes signed/unsigned comparison in conv2d (and transposed conv) bounds checks for input/output coordinates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Summary
fix gcc binary test
broken after: #18142
Test plan
ci