You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have no idea about the compatibility issues when Julia version is lower than v1.0 :(
I'll look through the rest of the PR when I have bit more time, but just a quick response on this: I think we could probably drop julia 0.7 support at this point. I think we should keep 1.0 support, given that that is the long term supported version of julia.
There seems to be some strange issues in Julia v1.0. I cannot solve it on my own so I went to community for help. https://discourse.julialang.org/t/strange-bug-segmentation-fault-11-solely-existed-in-julia-v1-0/21392
Also, I've already made total simplification for table_query_macros.jl, becoming capable of raising an error when users' input is not in expected case, which I think might be what you expect but don't have time to deal with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You may want to check this clean implementation of @select:
https://github.com/thautwarm/Query.jl/blob/34f6dbaf5aba156fafa9d60335126a7795f6b676/src/table_query_macros.jl#L49
Also, there're some prospective bugs that've been avoided, e.g., quoted
"in fieldname of dataframes.