Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up legacy dependencies and configuration files, and enhances the packaging workflow.
- Removes Tornado and Twisted extras and mypy overrides from
pyproject.toml - Updates
Makefileto cleardist/before building and prompt for interactive PyPI tokens - Deletes outdated manifest, author, Travis CI, and GitHub Actions README files
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Dropped legacy tornado and twisted extras and mypy overrides |
| Makefile | Added rm -rf dist/ and interactive token prompts for uploads |
| MANIFEST.in | Removed legacy include patterns for sdist |
| AUTHORS | Removed project authors file |
| .travis.yml | Deleted old Travis CI config |
| .github/README.md | Deleted legacy GitHub Actions documentation |
Comments suppressed due to low confidence (2)
Comment on lines
+11
to
+15
| bash -c 'read -s -p "Enter your Production PyPI token: " TWINE_PASSWORD; echo; export TWINE_PASSWORD; python -m twine upload dist/*' | ||
|
|
||
| upload-test: build | ||
| export TWINE_USERNAME=__token__ | ||
| python -m twine --repository testpypi upload dist/* | ||
| bash -c 'read -s -p "Enter your Test PyPI token: " TWINE_PASSWORD; echo; export TWINE_PASSWORD; python -m twine upload --repository testpypi dist/*' |
There was a problem hiding this comment.
Interactive prompts in the Makefile can break automated CI/CD. Consider reading TWINE_PASSWORD from the environment when set and only falling back to read -s when it’s missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.