feat: stop overriding jvmargs by default#173
Open
devnev wants to merge 1 commit intoreact-native-community:mainfrom
Open
feat: stop overriding jvmargs by default#173devnev wants to merge 1 commit intoreact-native-community:mainfrom
devnev wants to merge 1 commit intoreact-native-community:mainfrom
Conversation
cortinico
approved these changes
Jul 15, 2023
fotos
force-pushed
the
no-default-jvmargs
branch
from
4caf9aa to
8a96a34
Compare
fotos
approved these changes
Feb 10, 2024
fotos
force-pushed
the
no-default-jvmargs
branch
from
8a96a34 to
a53f569
Compare
Collaborator
|
@devnev is this still relevant? Shall I mark it as a breaking change and merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, builds will use
org.gradle.jvmargsdefined in thegradle.propertiesfile.As discussed in #171.
Validated with
./scripts/pack.sh && circleci orb validate packed-orb.yml