Skip to content

Prepare 3.3.0 release and update master to main#1363

Open
justin808 wants to merge 1 commit intomainfrom
jg-/tacoma
Open

Prepare 3.3.0 release and update master to main#1363
justin808 wants to merge 1 commit intomainfrom
jg-/tacoma

Conversation

@justin808
Copy link
Collaborator

Summary

Prepares the repository for the 3.3.0 release and updates all internal documentation links from the master branch to the main branch. The 3.3.0 release adds support for Propshaft server rendering.

Changes

  • Updated CHANGELOG.md with 3.3.0 release entry (2024-11-22)
  • Updated all internal GitHub links from /blob/master/ and /tree/master/ to /blob/main/ and /tree/main/
  • Updated VERSIONS.md to reflect main branch instead of master

Pull Request checklist

  • Update documentation
  • Update CHANGELOG file
  • [ ] Add/update test to cover these changes

- Updated CHANGELOG.md with 3.3.0 release for Propshaft support
- Renamed master branch references to main in documentation links
- Updated VERSIONS.md to show main branch instead of master
@justin808
Copy link
Collaborator Author

@claude review this PR.

@claude
Copy link

claude bot commented Feb 15, 2026

Claude finished @justin808's task in 2m 4s —— View job


PR Review: 3.3.0 Release and Master to Main Migration

Todo List

  • Check for CLAUDE.md and repo-specific guidelines
  • Read all changed files
  • Review CHANGELOG.md updates
  • Review master->main link updates
  • Search for any missed master references
  • Provide comprehensive review feedback

Summary

This PR prepares the 3.3.0 release and updates documentation links from the master branch to main. The changes are well-structured and mostly complete, but I found a few issues that should be addressed.

Issues Found

1. Incorrect Release Date in CHANGELOG.md (Line 18)

Severity: Medium

The CHANGELOG shows the release date as 2024-11-22, but the commit was made on 2025-11-22. This is a typo.

## [3.3.0] - 2024-11-22  ❌

Should be:

## [3.3.0] - 2025-11-22  ✅

Fix this →

2. External Repository References Still Use Master

Severity: Low (informational)

Some links to external repositories still reference master:

  • README.md:21 - https://github.com/shakacode/react_on_rails/tree/master/node_package
  • docs/common-errors.md:40 - https://github.com/cowboyd/therubyracer/blob/master/therubyracer.gemspec#L20
  • docs/common-errors.md:46 - https://github.com/shakacode/shakapacker/blob/master/docs/react.md#enabling-hot-module-replacement-hmr

Note: These are links to external repositories (not react-rails), so they should only be updated if those external repos have actually migrated to main as their default branch. You should verify the correct branch names for each external repository:

  • Check if shakacode/react_on_rails uses main or master
  • Check if cowboyd/therubyracer uses main or master
  • Check if shakacode/shakapacker uses main or master

What Looks Good ✅

  1. CHANGELOG Structure: The 3.3.0 entry is properly formatted and positioned correctly at the top of the version history.

  2. Version Links: The version comparison links at the bottom of CHANGELOG.md are correctly updated:

    • [Unreleased] now points to v3.3.0...main (was v3.2.1...main)
    • New [3.3.0] link properly added: v3.2.1...v3.3.0
    • Fixed the duplicate [3.2.1] link issue
  3. Internal Documentation Links: All internal react-rails repository links have been correctly updated from master to main:

    • README.md:21 - ReactRailsUJS link ✅
    • README.md:23 - Migration guide link ✅
    • VERSIONS.md:12 - Branch name in table ✅
    • docs/get-started.md:338 - VERSIONS.md link ✅
  4. Content Accuracy: The Propshaft feature is properly credited to PR Add Propshaft server rendering support #1345 and the contributor.

Recommendations

  1. Fix the date typo - This should be corrected before merging to avoid confusion in the changelog history.

  2. Verify external repository branches - Check if the external repositories have migrated to main and update those links if appropriate (but this is optional and could be done in a separate PR).

  3. Consider testing the links - Verify that all updated GitHub links resolve correctly to ensure no broken documentation.

Overall Assessment

The PR successfully accomplishes its primary goals:

  • ✅ Prepares the 3.3.0 release with proper changelog entry
  • ✅ Updates all internal react-rails repository links from master to main
  • ⚠️ Minor date typo needs correction

With the date fix, this PR will be ready to merge.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant