-
Notifications
You must be signed in to change notification settings - Fork 7.9k
More claude stuff #8280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More claude stuff #8280
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
src/content/reference/react/hooks.md
Outdated
| You can also create an event to fire from any Effect hook using: | ||
| - [`useEffectEvent`](/reference/react/useEffectEvent) lets you extract non-reactive logic from Effects into reusable functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops i'll remove this, it should be in #8279
|
This is amazing! I love how we’re finally able to “encode” our style and voice for the docs into something more repeatable. For the last example prompt you gave: you’re still orchestrating a bit w the prompt. should we have a higher-level skill for that? Eg should it be as simple as |
|
@josephsavona yeah for sure, I'm still iterating on that prompt a bit to see what works the best |
Overview
Adds more claude stuff.
I iterated on this throughout the
useOptimistic,useEffectEventanduseActionStatedoc revamps.To create/update these, I had claude comb through the existing docs more throughly to create exhastive rules in each section, then i had it go over them with the skills superpower to consolidate the repetition into the right skills (e.g. voice things in the docs-voice skill). Rinse and repeat until it was working pretty well.
Then I had it run a verification plan where it would create some sham docs, and then run the
/docs-revieweron them, iteratively improving the skills for thing that the skills, or reviewer agent missed.Finally, I had it do the
useEffectEventdocs, and then edited them by hand to do an editorial pass, then had claude review the diff and update the skills needed to write it with my edits. I'll probably do that more in the future PRs and just land the claude files in each PR iteratively.SKILL Improvements
docs-voiceskill that consolidates and expands on the brand voice rulesdocs-writer-blogskill for writing blog postsdocs-writer-learn: expandeddocs-writer-reference: expanded a tondocs-writer-components: expanded with all componentsdocs-writer-sandpack: expanded with thing i found it missedNew
/review-docsskillThe docs-reviewer agent was completely redone. Now there's a
/review-docsskill that spawns adocs-revieweragent for each skill (docs-components, docs-sandpack, etc). The reviewer agent creates a task list of things to review for that skill, and then reviews the the changes for conformance:That gives an output of feedback at the end like this:
New
/react-expertagentAdds a
/react-expertagent that understands concepts/APIs from the react repo using:This thing is nuts, but really useful.
Workflow for editing docs
This prompt worked really well for useEffectEvent:
Here's the plan it ran
And this commit was the output.