Add allow_underscore_prefixed_names option to unused_parameter#6509
Merged
SimplyDanny merged 1 commit intorealm:mainfrom Mar 5, 2026
Merged
Conversation
Contributor
Author
|
Aligned this with discussion in #5741 by keeping behavior unchanged by default and making underscore-prefixed names opt-in via Happy to adjust naming or scope if maintainers prefer a different config shape. |
2 tasks
Generated by 🚫 Danger |
SimplyDanny
approved these changes
Mar 5, 2026
Collaborator
SimplyDanny
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
105ea39 to
ae011ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new
unused_parameterconfiguration option:allow_underscore_prefixed_names(default:false)When enabled, unused parameters whose names start with
_are treated as intentionally unused and won't trigger violations.Changes
UnusedParameterConfigurationwith:severityallow_underscore_prefixed_namesUnusedParameterRuleto use the new config and skip violations for_-prefixed names when enabled.Main > Enhancements.Testing
SWIFTPM_ENABLE_KEYCHAIN=0 swift run swiftlint lint Source/SwiftLintBuiltInRules/Rules/Lint/UnusedParameterRule.swift Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/UnusedParameterConfiguration.swift Tests/FrameworkTests/RuleConfigurationTests.swiftSWIFTPM_ENABLE_KEYCHAIN=0 swift test --filter UnusedParameterRuleGeneratedTestsSWIFTPM_ENABLE_KEYCHAIN=0 swift test --filter RuleConfigurationTestsCloses #5741