Add Instructions on Supporting PHP Version Ranges#3600
Closed
Kenneth-Sills wants to merge 2 commits intorectorphp:mainfrom
Closed
Add Instructions on Supporting PHP Version Ranges#3600Kenneth-Sills wants to merge 2 commits intorectorphp:mainfrom
Kenneth-Sills wants to merge 2 commits intorectorphp:mainfrom
Conversation
I've documented two approaches: 1. The way ECS and Rector do it - developing at the highest version and releasing downgraded codebases. 2. The way mentioned in upstream rector/rector#9646, by keeping trunk backwards-compatible with the minimum supported version. For (1), I did not go into detail on downgrading and shipping dependencies. Might be worth creating separate documentation in a new blog post?
Author
|
Closing, since the feature is unwanted. Opened so maintainers could see the typos and cherry-pick the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent Ticket: rectorphp/rector#9646
Adds documentation on supporting multiple PHP version ranges and adds documentation on a new
->withEagerlyResolvedDeprecation(...)flag to more optimistically apply deprecation rules.I also fixed a couple of typos on the page while I was here.