[BetterPhpDocParser] Resolve class references in Generic PHPDoc tag node containing "::"#7895
Open
ruudk wants to merge 1 commit intorectorphp:mainfrom
Open
[BetterPhpDocParser] Resolve class references in Generic PHPDoc tag node containing "::"#7895ruudk wants to merge 1 commit intorectorphp:mainfrom
ruudk wants to merge 1 commit intorectorphp:mainfrom
Conversation
Member
|
I'd prefer generic solution that would not require configuration per project. |
Contributor
Author
|
How would you like to do that with a custom phpdoc like this? I believe this was done for performance reasons? |
Member
|
I am on mobile, how about just remove the : This of course need to verify other decorator that doing similar logic on different docblock node to avoid overwritten. |
Contributor
Author
|
Yeah i think that would be fine too! |
ruudk
force-pushed
the
custom-phpdoc-tags-with-class-reference
branch
from
bbaf88a to
a111b8f
Compare
ruudk
changed the title
ruudk
force-pushed
the
custom-phpdoc-tags-with-class-reference
branch
from
a111b8f to
bb39d91
Compare
Contributor
Author
|
Updated the PR. This is much simpler. Thanks! |
ruudk
force-pushed
the
custom-phpdoc-tags-with-class-reference
branch
from
bb39d91 to
017d054
Compare
samsonasik
approved these changes
Feb 16, 2026
Member
|
@ruudk please update PR title to something like: since it apply only on Generic. |
ruudk
changed the title
Contributor
Author
|
Done, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.