Pull Ginkgo test cases from argocd-operator repo#1058
Pull Ginkgo test cases from argocd-operator repo#1058Naveena-058 wants to merge 7 commits intoredhat-developer:masterfrom
Conversation
|
/test v4.14-kuttl-sequential |
1 similar comment
|
/test v4.14-kuttl-sequential |
|
/test v4.14-kuttl-sequential |
|
/test v4.19-kuttl-sequential |
Naveena-058
force-pushed
the
1.19.0-sync-ginkgo-tests-from-argocd-operator-
branch
from
78903bb to
3535785
Compare
|
/test v4.14-kuttl-parallel |
|
/test v4.14-kuttl-parallel |
|
/test v4.14-kuttl-sequential |
|
/test v4.14-kuttl-parallel |
test/openshift/e2e/ginkgo/parallel/1-121_validate_image_updater_test.go
Outdated
Show resolved
Hide resolved
Naveena-058
force-pushed
the
1.19.0-sync-ginkgo-tests-from-argocd-operator-
branch
from
00fadbf to
4e8422c
Compare
|
/test v4.14-kuttl-parallel |
|
/test v4.19-kuttl-sequential |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Naveena-058
force-pushed
the
1.19.0-sync-ginkgo-tests-from-argocd-operator-
branch
from
0bdcc70 to
105eaf1
Compare
|
/test v4.14-kuttl-parallel |
|
/test v4.19-kuttl-sequential |
1 similar comment
|
/test v4.19-kuttl-sequential |
| By("checking environment compatibility for image updater") | ||
| // Skip test in known problematic environments | ||
| if os.Getenv("CI") == "prow" { | ||
| Skip("Image updater controller has known issues in CI environments - skipping to prevent flaky failures") |
There was a problem hiding this comment.
@Naveena-058 can you add the known issue? The test doesn't pass locally as well so it would be better to make it compatible at least in our downstream CI
| Eventually(configMap, "8m", "10s").Should(k8sFixture.ExistByName(), "ConfigMap did not exist within timeout") | ||
|
|
||
| // Refresh the ConfigMap to get the latest data from the API server | ||
| Expect(k8sClient.Get(ctx, client.ObjectKeyFromObject(configMap), configMap)).To(Succeed()) |
There was a problem hiding this comment.
Do we need an additional get here? Seems like the previous statement does it for us
Signed-off-by: NAVEENA S <nas@redhat.com>
Signed-off-by: NAVEENA S <nas@redhat.com>
Signed-off-by: NAVEENA S <nas@redhat.com>
Signed-off-by: NAVEENA S <nas@redhat.com>
Signed-off-by: NAVEENA S <nas@redhat.com>
Naveena-058
force-pushed
the
1.19.0-sync-ginkgo-tests-from-argocd-operator-
branch
from
5b6e29a to
f94648b
Compare
Signed-off-by: NAVEENA S <nas@redhat.com>
|
@Naveena-058: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: NAVEENA S <nas@redhat.com>
|
/test v4.19-kuttl-parallel |
3 participants
For 1.19.0 build, Pull Ginkgo test cases from argocd-operator repo and integrate them into gitops-operator test structure
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
This PR pulls additional Ginkgo test cases from the argocd-operator repository and integrates them into the gitops-operator test structure to improve test coverage for the 1.19.0 build.