Skip to content

chore: add e2e tests for argocd-agent web-based terminal feature#1107

Open
jparsai wants to merge 3 commits intoredhat-developer:masterfrom
jparsai:agent-terminal-e2e
Open

chore: add e2e tests for argocd-agent web-based terminal feature#1107
jparsai wants to merge 3 commits intoredhat-developer:masterfrom
jparsai:agent-terminal-e2e

Conversation

@jparsai
Copy link
Copy Markdown
Collaborator

@jparsai jparsai commented Mar 27, 2026 •
edited
Loading

This PR is to add e2e tests for argocd-agent web-based terminal, since gitops-operator tests run on OCP, it is goot to verify that agent features work on OCP without any issue.

/kind enhancement

Assisted by: Cursor

ArgoCD Agent PR having fix for web-terminal in OCP argoproj-labs/argocd-agent#848

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign varshab1210 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 27, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jparsai jparsai force-pushed the agent-terminal-e2e branch 2 times, most recently from 056cc91 to 736c7ca Compare March 27, 2026 08:43
@jparsai jparsai marked this pull request as ready for review March 27, 2026 08:44
@openshift-ci openshift-ci bot requested review from Naveena-058 and jgwest March 27, 2026 08:44
@jparsai jparsai force-pushed the agent-terminal-e2e branch 4 times, most recently from 4d460e6 to c41eef0 Compare March 29, 2026 12:24
@jparsai
Copy link
Copy Markdown
Collaborator Author

jparsai commented Mar 30, 2026

Failing in Redis HA tests, which is not changed in this PR
/test v4.19-kuttl-sequential

@jparsai
Copy link
Copy Markdown
Collaborator Author

jparsai commented Mar 30, 2026

/test v4.14-kuttl-sequential

1 similar comment
@jparsai
Copy link
Copy Markdown
Collaborator Author

jparsai commented Mar 30, 2026

/test v4.14-kuttl-sequential

@jgwest
Copy link
Copy Markdown
Member

jgwest commented Mar 30, 2026

@jparsai - if you keeping hitting test timeout for 4.14 (e.g. ginkgo test that fails with [TIMEDOUT]), feel free to increase:

	$(GINKGO_CLI) -v --trace --timeout 180m -r ./test/openshift/e2e/ginkgo/sequential

to

	$(GINKGO_CLI) -v --trace --timeout 210m -r ./test/openshift/e2e/ginkgo/sequential

In Makefile. I looked at the log failure, and did not see any tests there were taking much longer than they should, so it appears we are just hitting the time limit.

@jparsai jparsai force-pushed the agent-terminal-e2e branch from c41eef0 to 4788567 Compare March 30, 2026 17:00
@jparsai
Copy link
Copy Markdown
Collaborator Author

jparsai commented Mar 31, 2026

Failed due to 502 Bad Gateway from quay.io
/test v4.14-kuttl-sequential
/test v4.19-kuttl-sequential

@jparsai
Copy link
Copy Markdown
Collaborator Author

jparsai commented Mar 31, 2026

Failed due to setup error

could not run steps: step kuttl-sequential failed: "kuttl-sequential" pre steps failed: "kuttl-sequential" pod "kuttl-sequential-ipi-conf-aws-byo-ipv4-pool-public" failed: could not watch pod: the pod ci-op-09g6sn9q/kuttl-sequential-ipi-conf-aws-byo-ipv4-pool-public failed after 37s (failed containers: test): ContainerFailed one or more containers exited

/test v4.14-kuttl-sequential

@jparsai
Copy link
Copy Markdown
Collaborator Author

jparsai commented Mar 31, 2026

Failed again to initializing pod.
/test v4.19-kuttl-sequential

jgwest
jgwest requested changes Apr 7, 2026
View reviewed changes
test/openshift/e2e/ginkgo/sequential/1-053_validate_argocd_agent_principal_connected_test.go
Auth: "mtls:CN=([^,]+)",
LogLevel: "info",
Image: common.ArgoCDAgentPrincipalDefaultImageName,
// TODO: Use the argocd-agent image once it is released
Copy link
Copy Markdown
Member

@jgwest jgwest Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than using a personal image, lets wait for ArgoCDAgentPrincipalDefaultImageName to be updated in upstream before we merge.

Copy link
Copy Markdown
Collaborator Author

@jparsai jparsai Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since 0.8.x release out, now we have agent image available having fix for OCP. I raised upstream PR, will wait for it to be merged first argoproj-labs/argocd-operator#2157

Copy link
Copy Markdown
Collaborator Author

@jparsai jparsai Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR #1124 will upgrade argocd-operator version which has 0.8.1 upstream image of agent. Will revert custom image name here once it is merged.

test/openshift/e2e/ginkgo/sequential/1-053_validate_argocd_agent_principal_connected_test.go
LogLevel: "info",
Image: common.ArgoCDAgentAgentDefaultImageName,
// TODO: Use the argocd-agent image once it is released
Image: "quay.io/jparsai/argocd-agent:1.20.1",
Copy link
Copy Markdown
Member

@jgwest jgwest Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@jparsai jparsai force-pushed the agent-terminal-e2e branch from 4788567 to 6d0070e Compare April 9, 2026 07:01
jparsai added 3 commits April 11, 2026 14:44
@jparsai
chore: add e2e tests for argocd-agent web-based terminal feature
9ea022c 
Assisted by: Cursor

Signed-off-by: Jayendra Parsai <jparsai@redhat.com>
@jparsai
chore: increase test timeout
a7e622a 
Signed-off-by: Jayendra Parsai <jparsai@redhat.com>
@jparsai
test: update e2e implementation
df44942 
Signed-off-by: Jayendra Parsai <jparsai@redhat.com>
@jparsai jparsai force-pushed the agent-terminal-e2e branch from 68d8f23 to df44942 Compare April 11, 2026 09:15
@jparsai
Copy link
Copy Markdown
Collaborator Author

jparsai commented Apr 11, 2026

Raised another PR #1124 to upgrade argocd-operator version. Wait for that to be merged first as we need dependency upgrade for these e2e to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgwest jgwest jgwest requested changes

@Naveena-058 Naveena-058 Awaiting requested review from Naveena-058

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jparsai @jgwest