feat(snc): add --profile flag with virtualization addon support for OCP SNC#738
Conversation
jangel97
force-pushed
the
feature/ocp-snc-virt
branch
from
44d8348 to
73fe0d6
Compare
| kcFlag := fmt.Sprintf("--kubeconfig %s", ClientKubeconfigPath) | ||
|
|
||
| applyOperators := fmt.Sprintf( | ||
| "sudo bash -c 'cat <<\"EOFMANIFEST\" | oc apply %s -f -\n%s\nEOFMANIFEST'", |
There was a problem hiding this comment.
Can you do it programatically? use the golang client to connect to the cluster instead
pkg/provider/aws/action/snc/snc.go
Outdated
| pulumi.ToSecret(kubeconfig)) | ||
| // Deploy profiles using Kubernetes provider | ||
| if len(r.profiles) > 0 { | ||
| k8sProvider, err := kubernetes.NewProvider(ctx, "k8s-provider", &kubernetes.ProviderArgs{ |
There was a problem hiding this comment.
Should not this be part of the common (target/service/snc) side for snc, you can create client.go there
There was a problem hiding this comment.
Good point, I just moved it to service layer so it can be reused in other providers.
| kcFlag := fmt.Sprintf("--kubeconfig %s", ClientKubeconfigPath) | ||
| waitCSV, err := args.RunCommand(ctx, | ||
| fmt.Sprintf( | ||
| `sudo bash -c 'until oc get csv %s -n %s -o jsonpath="{.items[0].status.phase}" 2>/dev/null | grep -q Succeeded; do echo "Waiting for CNV CSV..."; sleep 15; done'`, |
There was a problem hiding this comment.
Why is this sill sing oc instead of k8s client as the deploy?
There was a problem hiding this comment.
I missed it, should be gone, no more "oc" commands.
jangel97
force-pushed
the
feature/ocp-snc-virt
branch
6 times, most recently
from
d2f13f1 to
677ecb0
Compare
jangel97
force-pushed
the
feature/ocp-snc-virt
branch
from
677ecb0 to
09b8212
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
jangel97
force-pushed
the
feature/ocp-snc-virt
branch
from
09b8212 to
f153f72
Compare
There was a problem hiding this comment.
We need to include the option in the tekton task https://github.com/redhat-developer/mapt/blob/main/tkn/template/infra-aws-ocp-snc.yaml
jangel97
force-pushed
the
feature/ocp-snc-virt
branch
2 times, most recently
from
c8d8f81 to
273a78e
Compare
Add a profile system to the OpenShift SNC command that allows installing addons on the cluster after deployment. The first supported profile is 'virtualization' which installs the OCP Virtualization (CNV) operator and enables nested virtualization on the compute instance. Signed-off-by: Jose Angel Morena <jmorenas@redhat.com>
jangel97
force-pushed
the
feature/ocp-snc-virt
branch
from
273a78e to
7ec787a
Compare
2 participants
Add a profile system to the OpenShift SNC command that allows installing addons on the cluster after deployment. The first supported profile is 'virtualization' which installs the OCP Virtualization (CNV) operator and enables nested virtualization on the compute instance.