Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Python modules were still pinned to the old Replit Poetry fork and prebuilt bundle tarballs even though upstream Poetry has caught up on the resolver and installer improvements we originally needed.
What changed
poetrypkgs.poetry.override { python3 = python; }so installs land in the matching.pythonlibs/lib/pythonX.Y/site-packagespython-baseto use the same upstream per-Python Poetry packageTest plan
nix shell nixpkgs#nixpkgs-fmt -c nixpkgs-fmt pkgs/poetry/default.nix pkgs/modules/python/default.nix pkgs/modules/python-base/default.nixnix build --impure --no-link --print-out-paths --expr 'let flake = builtins.getFlake (toString /home/developer/replit/nixmodules); pkgs = import flake.inputs.nixpkgs { system = "x86_64-linux"; overlays = [ flake.overlays.default flake.inputs.prybar.overlays.default flake.inputs.java-language-server.overlays.default flake.inputs.nil.overlays.default flake.inputs.fenix.overlays.default flake.inputs.replit-rtld-loader.overlays.default ]; config.allowUnfreePredicate = pkg: true; }; in pkgs.callPackage /home/developer/replit/nixmodules/pkgs/poetry { python = pkgs.python312; }'nix eval --impure --json --expr 'let flake = builtins.getFlake (toString /home/developer/replit/nixmodules); pkgs = import flake.inputs.nixpkgs { system = "x86_64-linux"; overlays = [ flake.overlays.default flake.inputs.prybar.overlays.default flake.inputs.java-language-server.overlays.default flake.inputs.nil.overlays.default flake.inputs.fenix.overlays.default flake.inputs.replit-rtld-loader.overlays.default ]; config.allowUnfreePredicate = pkg: true; }; mod = import /home/developer/replit/nixmodules/pkgs/modules/python { python = pkgs.python312; pypkgs = pkgs.python312Packages; }; cfg = mod { pkgs-unstable = pkgs; lib = pkgs.lib; }; in { poetryCache = cfg.replit.env.POETRY_CACHE_DIR; poetryCreatesVenv = cfg.replit.env.POETRY_VIRTUALENVS_CREATE; poetryPackage = builtins.elemAt cfg.replit.packages 2; }'nix eval --impure --json --expr 'let flake = builtins.getFlake (toString /home/developer/replit/nixmodules); pkgs = import flake.inputs.nixpkgs { system = "x86_64-linux"; overlays = [ flake.overlays.default flake.inputs.prybar.overlays.default flake.inputs.java-language-server.overlays.default flake.inputs.nil.overlays.default flake.inputs.fenix.overlays.default flake.inputs.replit-rtld-loader.overlays.default ]; config.allowUnfreePredicate = pkg: true; }; mod = import /home/developer/replit/nixmodules/pkgs/modules/python-base { python = pkgs.python313; pypkgs = pkgs.python313Packages; }; cfg = mod { pkgs-unstable = pkgs; pkgs-23_05 = pkgs; lib = pkgs.lib; }; in { poetryPackage = builtins.elemAt cfg.replit.packages 2; pythonUserbase = cfg.replit.env.PYTHONUSERBASE; }'poetry new demo && poetry add cowsay, then verify the package imports from.pythonlibs/lib/python3.12/site-packagesRollout
No special rollout steps.
~ written by Zerg 👾 (mutated-devourer-dbbe)