Conversation
Deploying rescript-lang-org with
|
| Latest commit: |
3a6e3e8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cc8f0371.rescript-lang.pages.dev |
| Branch Preview URL: | https://roadmap-let-unwrap.rescript-lang.pages.dev |
9bfb0c6 to
68931f9
Compare
|
Assistant:
looks spot on to me |
Seems legit, except the last suggestion might be too much |
|
Btw |
68931f9 to
156ad3c
Compare
| ->Result.flatMapOkAsync(decodedUser => ensureUserActive(decodedUser)) | ||
| ``` | ||
|
|
||
| **Note**: `Result.flatMapOkAsync` among some other async result helper functions are brand new in ReScript 12 as well! |
There was a problem hiding this comment.
nojaf
left a comment
There was a problem hiding this comment.
This looks good and I think it’s ready to go.
One feeling I still get is that it reads like a new idea we haven't really tested in our codebase. I'm not sure if that's an issue or worth mentioning, but it's hard to tell whether this will be game-changing or not.
7c30336 to
3a6e3e8
Compare
| ```json | ||
| { | ||
| "experimental-features": { | ||
| "letUnwrap": true |
There was a problem hiding this comment.
| "letUnwrap": true | |
| "LetUnwrap": true |
Closes #1086