Clarify what request-header-size and response-header-size mean#440
Open
mikekap wants to merge 1 commit intoring-clojure:masterfrom
Open
Clarify what request-header-size and response-header-size mean#440mikekap wants to merge 1 commit intoring-clojure:masterfrom
mikekap wants to merge 1 commit intoring-clojure:masterfrom
Conversation
|
Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:
|
Member
|
Do you have a source for that? I ask not to doubt, but so we have a record of why changes were made. |
Author
|
Unfortunately Jetty hasn't quite updated the docs, but this was the only source that I could find: jetty/jetty.project#6204 (comment) . The other way is to read through the code and notice that the length is used to allocate a buffer that includes the status line and all the headers. |
Jetty's config options are for the PROTOCOL header, not a single Field: Value pair. So these options control the sum of all headers and status lines.
Member
|
Thanks. From my reading of the link you provided, the sizes don't include the request/response line. |
0d7f29a to
0103527
Compare
13fdd61 to
475f4dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jetty's config options are for the PROTOCOL header, not a single Field: Value pair. So these options control the sum of all headers and status lines.