feat: unified async RiveFonts.addFallbackFont(source) API#152
Draft
feat: unified async RiveFonts.addFallbackFont(source) API#152
Conversation
Replace separate addFallbackFont/addFallbackFontFromResource/addFallbackFontFromURL with a single addFallbackFont(source: FontSource) that accepts require() IDs, URI objects, resource names, URLs, or raw ArrayBuffer bytes. All methods are now async. Renamed native HybridObject from Rive to RiveFontConfig to better reflect its purpose.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| customFonts.add(fontBytes) | ||
| resetFontCache() | ||
| return@async | ||
| } catch (_: Exception) {} |
Contributor
There was a problem hiding this comment.
🚫 [ktlint] standard:try-catch-finally-spacing reported by reviewdog 🐶
Expected a newline after '{'
| customFonts.add(fontBytes) | ||
| resetFontCache() | ||
| return@async | ||
| } catch (_: Exception) {} |
Contributor
There was a problem hiding this comment.
🚫 [ktlint] standard:try-catch-finally-spacing reported by reviewdog 🐶
Expected a newline before '}'
The font file existed in example/ios/ but wasn't referenced in the Xcode project, so addFallbackFontFromResource couldn't find it at runtime.
Prevents "Cannot set value for property" error on initial render when the riv file hasn't loaded yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces separate
addFallbackFont/addFallbackFontFromResource/addFallbackFontFromURLwith a singleaddFallbackFont(source: FontSource)that acceptsrequire()IDs, URI objects, resource names, URLs, or rawArrayBufferbytes. All methods are now async. Renamed native HybridObject fromRivetoRiveFontConfig.Test plan
Use the Font Fallback exerciser in the example app (
exercisers/FontFallbackExample.tsx).System font fallback (no custom fonts)
URL-loaded font
Bundled resource font
Multiple fonts
Reset flow