Guarantee output order in batch insertion example#1206
Merged
Conversation
Aims to fix an intermittently failing example wherein we can print an "Inserted ..." message after the work messages coming from each inserted job. https://github.com/riverqueue/river/actions/runs/24310710305/job/70979718727 --- FAIL: Example_batchInsert (0.09s) got: Worked a job Worked a job Worked a job Worked a job Worked a job Inserted 5 jobs want: Inserted 5 jobs Worked a job Worked a job Worked a job Worked a job Worked a job FAIL FAIL github.com/riverqueue/river 26.753s The fix is pretty straightforward in making sure we do the inserts (and therefore print the right message) before starting the client and introducing the possibility that jobs can be worked.
bgentry
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to fix an intermittently failing example wherein we can print an
"Inserted ..." message after the work messages coming from each inserted
job.
https://github.com/riverqueue/river/actions/runs/24310710305/job/70979718727
The fix is pretty straightforward in making sure we do the inserts
(and therefore print the right message) before starting the client and
introducing the possibility that jobs can be worked.