Cache unwrap and to_type_signature on type wrappers#5585
Open
swalkinshaw wants to merge 1 commit intomasterfrom
Open
Cache unwrap and to_type_signature on type wrappers#5585swalkinshaw wants to merge 1 commit intomasterfrom
unwrap and to_type_signature on type wrappers#5585swalkinshaw wants to merge 1 commit intomasterfrom
Conversation
Owner
|
It looks like some tests are failing because of the type definition being frozen. I'm open to any solution here, but my first thought is, what about adding: to |
Type wrappers (NonNull, List) are schema-level immutable objects whose unwrap and to_type_signature results never change. Memoize both to eliminate repeated recursive unwrap calls and string allocations during validation and introspection. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
swalkinshaw
force-pushed
the
cache-type-wrapper-results
branch
from
3a5677b to
e350409
Compare
Collaborator
Author
|
Good idea; added! |
Collaborator
Author
|
Last CI failure is flaky |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type wrappers (NonNull, List) are schema-level immutable objects whose
unwrapandto_type_signatureresults never change. Memoize both to eliminate repeated recursive unwrap calls and string allocations during validation and introspection.I can't find any reason why these wouldn't be safe to memoize.
Extracted from #5578