Open
Conversation
Contributor
There was a problem hiding this comment.
Curious why is this file needed vs a kotlin file? Looks painful to support this syntax too.
Is this required for turbo modules to work in a library? Also is this auto-generated? Some of the iOS files say this, but not here 🤷 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fight RN codegen with more codegen.
See also reactwg/react-native-new-architecture#199
Using swift and RN with new architecture but providing compatibility with old arch requires an insane amount of boilerplate code. See required files.
We attempt to work around this using the schema.json generated by RN codegen and generating as many boilerplate as possible with ejs templates. Ejs templates can have grey-matter metadata in comments in the front.
To run the codegen:
1.) Run
combine-js-to-schema-clito create the schema.json used internally by react native codegen toolcd example mkdir -p ../tmp/generated node ./node_modules/@react-native/codegen/lib/cli/combine/combine-js-to-schema-cli.js --platform android ../tmp/generated/schema.json ../src/specs/2.) Run rnmbxcodegen
Pros:
Cons:
Boilerplate:
On android it's better only 3 files: