chore(swc): fix typings to match actual exports#1985
Open
gwynne wants to merge 1 commit intorollup:masterfrom
Open
chore(swc): fix typings to match actual exports#1985gwynne wants to merge 1 commit intorollup:masterfrom
gwynne wants to merge 1 commit intorollup:masterfrom
Conversation
gwynne
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
swcThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
This PR makes a trivial correction to the plugin's declarations file so that it reflects that the
swcfunction is exported both by name and as the default export. This allows using the syntaximport { swc } from '@rollup/plugin-swc. At present, using this syntax causes Typescript to complainModule '"@rollup/plugin-swc"' has no exported member 'swc'. Did you mean to use 'import swc from "@rollup/plugin-swc"' instead? ts(2614), even though the import works correctly at runtime if you ignore the error (which will remain visible in, for example, VSCode).