Fix component registering in subdirectories (backport #3064)#3076
Open
mergify[bot] wants to merge 1 commit intohumblefrom
Open
Fix component registering in subdirectories (backport #3064)#3076mergify[bot] wants to merge 1 commit intohumblefrom
mergify[bot] wants to merge 1 commit intohumblefrom
Conversation
Signed-off-by: pum1k <55055380+pum1k@users.noreply.github.com> (cherry picked from commit fc1afcb)
ahcorde
approved these changes
Feb 19, 2026
Contributor
|
Pulls: #3076
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows using
rclcpp_components_register_nodeandrclcpp_components_register_nodesfunctions in subdirectories added byadd_subdirectory(and other non global scopes). This was done by storing the internal data in a property of the project directory instead of variable.Fixes: #1698
Is this user-facing behavior change?
Yes, users will be able to use the above mentioned functions inside nested scopes.
Did you use Generative AI?
No
This is an automatic backport of pull request #3064 done by [Mergify](https://mergify.com).