Fixes uninitialized constant Rack::Timeout::Error#5
Open
jeffcarbs wants to merge 1 commit intoruby-openid:masterfrom
Open
Fixes uninitialized constant Rack::Timeout::Error#5jeffcarbs wants to merge 1 commit intoruby-openid:masterfrom
jeffcarbs wants to merge 1 commit intoruby-openid:masterfrom
Conversation
In an application where I'm using this gem, I'm also using the rack-timeout gem (https://github.com/kch/rack-timeout), so use of Timeout inside the Rack::OpenID class was finding Rack::Timeout, which is not the same. This commit updates references to Timeout to use the root namespace (::Timeout).
|
👍 |
|
When is this going to get merged? |
|
Any update on when this might be merged? |
simeonwillbanks
pushed a commit
to stitchfix/rack-openid
that referenced
this pull request
Sep 24, 2014
ruby-openid#5 In an application where I'm using this gem, I'm also using the rack-timeout gem (https://github.com/kch/rack-timeout), so use of Timeout inside the Rack::OpenID class was finding Rack::Timeout, which is not the same. This commit updates references to Timeout to use the root namespace (::Timeout). Conflicts: lib/rack/openid.rb
|
👍 |
pboling
added a commit
to ruby-openid/rack-openid2
that referenced
this pull request
Sep 4, 2024
Member
|
Ah, crap I failed to merge this first. I'll cherry-pick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an application where I'm using this gem, I'm also using the
rack-timeout gem (https://github.com/kch/rack-timeout), so use of
Timeout inside the Rack::OpenID class was finding Rack::Timeout,
which is not the same. This commit updates references to Timeout to
use the root namespace (::Timeout).