x509attr: fix const-qualification for openssl-master#1007
Closed
swhitt wants to merge 1 commit intoruby:masterfrom
Closed
x509attr: fix const-qualification for openssl-master#1007swhitt wants to merge 1 commit intoruby:masterfrom
swhitt wants to merge 1 commit intoruby:masterfrom
Conversation
X509_ATTRIBUTE_get0_object() and X509_ATTRIBUTE_get0_type() return const pointers in OpenSSL master, causing -Werror build failures.
Contributor
Author
|
The |
Contributor
Author
|
This is fixed more comprehensively in #1005 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
X509_ATTRIBUTE_get0_object()andX509_ATTRIBUTE_get0_type()returnconstpointers in OpenSSL master, which breaks the build with-Werror=discarded-qualifiers.Noticed this while working on #1004 — the
openssl-masterCI job was already failing before that PR, and it's still failing on master now.