Remove special lex_compat token type classes
#3855
Draft
+1
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ruby#3849, I wondered why for the lex method I added some files as excludes for the first time. Turns out, the result contains different token types that lie about equality for `LexTest`. That seems useful only for testing, so I removed it. It's better to explicitly list the excludes and handle specially certain cases when asserting (like ignoring state for `on_heredoc_end`). Since `RipperLex` already contains full tests for the lex method, I removed the ones in `LexTest`. They make more sense in the ripper class to me. Also, some of the special token types were not necessary anymore, like `EndContentToken`. Probably was fixed at some point.
Collaborator
Author
|
Right, the CI lext step also needs this. I'll come back to this later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3849, I wondered why for the lex method I added some files as excludes for the first time. Turns out, the result contains different token types that lie about equality for
LexTest.That seems useful only for testing, so I removed it. It's better to explicitly list the excludes and handle specially certain cases when asserting (like ignoring state for
on_heredoc_end). SinceRipperLexalready contains full tests for the lex method (added in the PR linked above), I removed the ones inLexTest. They make more sense in the ripper class to me.Also, some of the special token types were not necessary anymore, like
EndContentToken. Probably was fixed at some point.