Skip to content

Reduce compile warnings #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soutaro merged 2 commits into from
Mar 10, 2026
+9 −4
Merged

Reduce compile warnings #2871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
461bedc
Reduce compile warning of `-Wjump-misses-init`
ksss Mar 10, 2026
2be8a57
Reduce compile warning of `-Wreturn-type`
ksss Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ext/rbs_extension/ast_translation.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ VALUE rbs_attr_ivar_name_to_ruby(rbs_translation_context_t ctx, rbs_attr_ivar_na
return Qnil;
case RBS_ATTR_IVAR_NAME_TAG_EMPTY:
return Qfalse;
default:
rb_fatal("unknown enum rbs_attr_ivar_name_tag ivar_name.tag: %d", ivar_name.tag);
}
}

Expand Down
7 changes: 4 additions & 3 deletions src/parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ static bool parse_params(rbs_parser_t *parser, method_params *params, bool self_
PARSE_OPTIONAL_PARAMS:
while (true) {
switch (parser->next_token.type) {
case pQUESTION:
case pQUESTION: {
rbs_parser_advance(parser);

if (is_keyword(parser)) {
Expand All @@ -533,6 +533,7 @@ static bool parse_params(rbs_parser_t *parser, method_params *params, bool self_
rbs_node_list_append(params->optional_positionals, (rbs_node_t *) param);

break;
}
default:
goto PARSE_REST_PARAM;
}
Expand Down Expand Up @@ -597,13 +598,13 @@ static bool parse_params(rbs_parser_t *parser, method_params *params, bool self_
}
break;

case pSTAR2:
case pSTAR2: {
rbs_parser_advance(parser);
rbs_types_function_param_t *param = NULL;
CHECK_PARSE(parse_function_param(parser, &param, self_allowed, classish_allowed));
params->rest_keywords = (rbs_node_t *) param;
break;

}
case tUIDENT:
case tLIDENT:
case tQIDENT:
Expand Down
4 changes: 3 additions & 1 deletion templates/ext/rbs_extension/ast_translation.c.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,10 @@ VALUE rbs_attr_ivar_name_to_ruby(rbs_translation_context_t ctx, rbs_attr_ivar_na
}
case RBS_ATTR_IVAR_NAME_TAG_UNSPECIFIED:
return Qnil;
case RBS_ATTR_IVAR_NAME_TAG_EMPTY:
case RBS_ATTR_IVAR_NAME_TAG_EMPTY:
return Qfalse;
default:
rb_fatal("unknown enum rbs_attr_ivar_name_tag ivar_name.tag: %d", ivar_name.tag);
}
}

Expand Down