Skip to content

Add specs for IO.select with other Float special values as timeout #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
herwinw wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −0
Open

Add specs for IO.select with other Float special values as timeout #1338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
843faa6
Add spec for IO.select with -INFINITY as timeout
herwinw Jan 28, 2026
c2df414
Add spec for IO.select with NaN as timeout
herwinw Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions core/io/select_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,16 @@
-> { IO.select(nil, nil, nil, -5)}.should raise_error(ArgumentError)
end

ruby_version_is "4.0" do
it "raises an ArgumentError when passed negative infinity as timeout" do
-> { IO.select(nil, nil, nil, -Float::INFINITY)}.should raise_error(ArgumentError)
Copy link
Member

@eregon eregon Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the exception messages are meaningful it seems worth specifying it them here.
It'll also convenient when implementing those semantics, vs having to check what message CRuby uses.

end
end

it "raises an RangeError when passed NaN as timeout" do
-> { IO.select(nil, nil, nil, Float::NAN)}.should raise_error(RangeError)
end

describe "returns the available descriptors when the file descriptor" do
it "is in both read and error arrays" do
@wr.write("foobar")
Expand Down