Issue 6600: skip email confirmation when saving new volunteer email, due to how CASA orgs work

[Budmin]

What github issue is this PR for, if any?

Resolves #6600

What changed, and why?

Volunteers aren't sent a confirmation email before their email is updated, it just updates now.
This was changed because it's not needed for CASA's use case.

I also changed the "Submit" button to an "Update" button.
This wasn't in the Issue, I just thought it was more intuitive for users who don't realize they're submitting a form.

How is this tested? (please write rspec and jest tests!) 💖💪

Tests that checked for confirmation emails when updating Volunteer emails were either modified or replaced to check for the record and UI updating as expected.

Screenshots please :)

Run your local server and take a screenshot of your work! Try to include the URL of the page as well as the contents of the page.

(No email in between now...)

Submit -> Update button change

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

[Copilot]

Pull request overview

This PR simplifies the volunteer email update process by removing the email confirmation requirement. When an admin updates a volunteer's email, it now takes effect immediately instead of requiring the volunteer to confirm via email first. Additionally, the form submit button text was changed from "Submit" to "Update" for better UX clarity.

• Updated VolunteersController#update to call skip_reconfirmation! before updating volunteer records
• Changed button text from "Submit" to "Update" in the volunteer edit form
• Modified tests to verify immediate email updates without confirmation emails

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
app/controllers/volunteers_controller.rb	Added skip_reconfirmation! call to bypass Devise email confirmation when updating volunteers
app/views/volunteers/edit.html.erb	Changed button text from "Submit" to "Update" for improved user clarity
spec/system/volunteers/edit_spec.rb	Updated all button click actions from "Submit" to "Update" and replaced email confirmation tests to verify immediate email updates
spec/requests/volunteers_spec.rb	Modified email update test to verify immediate email change without confirmation email being sent

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[compwron]

Please fix merge conflicts so we can merge?

[Budmin]

@compwron Let me know if you need anything else from me.