WIP N+1 detector gem Prosopite (replacing gem Bullet) by compwron · Pull Request #6744 · rubyforgood/casa

compwron · 2026-03-03T03:20:28Z

Copilot

Pull request overview

Replaces Bullet with Prosopite for N+1 query detection, adding configuration for development/test (and optional production toggles) plus RSpec integration and an ignore mechanism to support gradual rollout.

Changes:

Swap bullet for prosopite in dependencies and environment config.
Add a Rails initializer to configure Prosopite (middleware + core settings).
Add RSpec support to scan examples, pause during FactoryBot creation, and support an ignore list / TODO tracking.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
spec/support/prosopite.rb	Adds RSpec + FactoryBot integration and ignore-list logic for Prosopite scanning
spec/.prosopite_ignore	Introduces ignore list file for incremental rollout
config/initializers/prosopite.rb	Configures Prosopite middleware/settings after Rails initialization
config/environments/test.rb	Enables Prosopite settings for test environment (replacing Bullet config)
config/environments/development.rb	Enables Prosopite settings for development environment (replacing Bullet config)
config/environments/production.rb	Adds env-driven Prosopite toggles for production
PROSOPITE_TODO.md	Captures detected N+1 locations for follow-up work
Gemfile.lock	Removes Bullet and adds Prosopite gem
Gemfile	Replaces Bullet with Prosopite dependency (dev/test group)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-20T18:32:18Z

config/initializers/prosopite.rb

+# Only enable Rack middleware if Prosopite is configured on
+if Rails.configuration.respond_to?(:prosopite_enabled) && Rails.configuration.prosopite_enabled
+  require "prosopite/middleware/rack"
+  Rails.configuration.middleware.use(Prosopite::Middleware::Rack)
+end
+
+Rails.application.config.after_initialize do
+  # Core settings
+  Prosopite.enabled = Rails.configuration.respond_to?(:prosopite_enabled) &&
+    Rails.configuration.prosopite_enabled
+
+  # Minimum repeated queries to trigger detection (default: 2)
+  Prosopite.min_n_queries = Rails.configuration.respond_to?(:prosopite_min_n_queries) ?
+                            Rails.configuration.prosopite_min_n_queries : 2
+
+  # Logging options
+  Prosopite.rails_logger = true                    # Log to Rails.logger
+  Prosopite.prosopite_logger = Rails.env.development?  # Log to log/prosopite.log
+end


Prosopite is referenced unconditionally inside after_initialize, but the gem is only in the :development, :test group. In production (and any env without the gem), this initializer will raise NameError during boot. Wrap the entire initializer (including the after_initialize block) in return unless defined?(Prosopite) / if defined?(Prosopite) or move the gem to a group that is bundled in the environments where this initializer runs (and handle the case where prosopite_enabled is true but the gem isn't available).

spec/support/prosopite.rb

Copilot · 2026-03-20T18:32:18Z

spec/support/prosopite.rb

+def use_prosopite?(example)
+  # Explicit metadata takes precedence
+  return false if example.metadata[:disable_prosopite]
+  return true if example.metadata[:enable_prosopite]
+
+  # Check against ignore list
+  PROSOPITE_IGNORE.none? do |path|
+    File.fnmatch?("./#{path}/*", example.metadata[:rerun_file_path].to_s)
+  end


use_prosopite? is defined at the top level, which adds a method to Object and can leak into other specs/helpers. Define it in a module (e.g., Support::Prosopite) and call it from the RSpec hook, or define it as a local lambda inside the RSpec.configure block to avoid global namespace pollution.

Copilot · 2026-03-20T18:32:19Z

spec/support/prosopite.rb

+
+# Optional: Load ignore list from file for gradual rollout
+PROSOPITE_IGNORE = if File.exist?("spec/.prosopite_ignore")
+  File.read("spec/.prosopite_ignore").lines.map(&:chomp).reject(&:empty?)


The ignore list loader keeps comment lines (starting with #) and doesn’t strip surrounding whitespace. That makes it easy to accidentally add a path like spec/features that never matches, and the file header comments will always be processed. Consider filtering out comment lines and trimming whitespace before matching.

Suggested change

File.read("spec/.prosopite_ignore").lines.map(&:chomp).reject(&:empty?)

File.read("spec/.prosopite_ignore").lines

.map { |line| line.strip }

.reject { |line| line.empty? || line.start_with?("#") }

Gemfile

- Set Prosopite.raise = true so N+1s fail specs instead of silently logging - Populate .prosopite_ignore with known-issue directories for gradual rollout - Scope initializer to development only; spec/support/prosopite.rb owns test config - Remove redundant prosopite settings from test.rb and production.rb - Replace fragile FactoryBot::Strategy::Create monkey-patch with SyntaxRunner hook - Filter comment lines in .prosopite_ignore parser Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-23T15:12:51Z

Gemfile

+group :development, :test, :production do
  gem "brakeman" # Security inspection
-  gem "bullet" # Detect and fix N+1 queries
+  gem "prosopite" # N+1 query detection via SQL pattern analysis


Changing this group to include :production will also bundle/require a large set of dev/test-only gems (e.g., rspec-rails, factory_bot_rails, linters) in production, increasing boot time/memory and potentially introducing production-only dependency conflicts. Keep the group as :development, :test and, if Prosopite truly needs to be available in production, place only prosopite in its own appropriate group (or mark it require: false) instead of pulling the entire dev/test toolchain into production.

Copilot · 2026-03-23T15:12:51Z

spec/support/prosopite.rb

+  PROSOPITE_IGNORE.none? do |path|
+    File.fnmatch?("./#{path}/*", example.metadata[:rerun_file_path].to_s)


The ignore matching here appears to use a nonstandard RSpec metadata key (:rerun_file_path), which is likely to be nil for most examples. That would prevent the ignore list from ever matching and cause Prosopite to run/raise in specs that are supposed to be ignored. Use the actual spec file path metadata key (e.g., :file_path/:absolute_file_path) when comparing against .prosopite_ignore.

Suggested change

PROSOPITE_IGNORE.none? do |path|

File.fnmatch?("./#{path}/*", example.metadata[:rerun_file_path].to_s)

spec_path = example.metadata[:absolute_file_path] ||

example.metadata[:file_path] ||

example.metadata[:rerun_file_path]

PROSOPITE_IGNORE.none? do |path|

File.fnmatch?("./#{path}/*", spec_path.to_s)

spec/support/prosopite.rb

github-actions bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Mar 3, 2026

compwron force-pushed the prosopite-2 branch from 8d1b97e to eeb3a2e Compare March 20, 2026 18:21

compwron marked this pull request as ready for review March 20, 2026 18:29

compwron requested review from FireLemons and elasticspoon as code owners March 20, 2026 18:29

compwron requested a review from Copilot March 20, 2026 18:29

compwron enabled auto-merge (rebase) March 20, 2026 18:29

Copilot started reviewing on behalf of compwron March 20, 2026 18:29 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

compwron requested a review from Copilot March 23, 2026 15:08

compwron and others added 7 commits March 23, 2026 08:08

add prosopite

1146c66

remove bullet now that we have prosopite

6bc37a9

prosopite todo list

7a8d67d

lintfix

d0f5517

Update Gemfile

85fd417

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update spec/support/prosopite.rb

f9cd33a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of compwron March 23, 2026 15:08 View session

compwron force-pushed the prosopite-2 branch from 7291c11 to f9cd33a Compare March 23, 2026 15:10

Copilot AI reviewed Mar 23, 2026

View reviewed changes

add ignore files for now

5769eb6

compwron force-pushed the prosopite-2 branch from 90a1f63 to 5769eb6 Compare March 23, 2026 23:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

WIP N+1 detector gem Prosopite (replacing gem Bullet)#6744

WIP N+1 detector gem Prosopite (replacing gem Bullet)#6744
compwron wants to merge 8 commits intomainfrom
prosopite-2

compwron commented Mar 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Copilot AI Mar 20, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		PROSOPITE_IGNORE.none? do \|path\|
		File.fnmatch?("./#{path}/*", example.metadata[:rerun_file_path].to_s)

Uh oh!

Conversation

compwron commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

compwron commented Mar 3, 2026 •

edited

Loading