Relocate binaries only when RELENV_BUILDENV is set.#274
Merged
dwoz merged 1 commit intosaltstack:mainfrom Feb 4, 2026
Merged
Conversation
twangboy
approved these changes
Feb 4, 2026
This change ensures that binary relocation (using readelf/patchelf or otool/install_name_tool) is only attempted during pip installs when the RELENV_BUILDENV environment variable is set, preventing unnecessary processing for standard installs. It also introduces logic to prefer the relenv toolchain's `readelf` and `patchelf` binaries on Linux when available, ensuring compatibility with the specific glibc version of the environment. Tests were added to verify: - Relocation logic is skipped when RELENV_BUILDENV is missing. - Relocation logic runs when RELENV_BUILDENV is set. - Toolchain binaries are correctly selected over system defaults on Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #273
This change ensures that binary relocation (using readelf/patchelf or otool/install_name_tool) is only attempted during pip installs when the RELENV_BUILDENV environment variable is set, preventing unnecessary processing for standard installs.
It also introduces logic to prefer the relenv toolchain's
readelfandpatchelfbinaries on Linux when available, ensuring compatibility with the specific glibc version of the environment.Tests were added to verify: