Skip to content

build: use minimum support @types/node@18 in development#2531

Open
zimeg wants to merge 2 commits intomainfrom
types18
Open

build: use minimum support @types/node@18 in development#2531
zimeg wants to merge 2 commits intomainfrom
types18

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Mar 3, 2026

Summary

This PR sets the @types/node package to ^18 in development dependencies to ensure patterns used in code are supported with our minimum supported node version 👾

The @slack/logger package removes this package from required dependencies for consumers since we don't surface this in methods!

Requirements

@zimeg zimeg self-assigned this Mar 3, 2026
@zimeg zimeg requested a review from a team as a code owner March 3, 2026 21:53
@zimeg zimeg added semver:patch area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` pkg:rtm-api applies to `@slack/rtm-api` pkg:webhook applies to `@slack/webhook` pkg:logger applies to `@slack/logger` pkg:types applies to `@slack/types` pkg:oauth applies to `@slack/oauth` pkg:socket-mode applies to `@slack/socket-mode` pkg:cli-hooks applies to `@slack/cli-hooks` pkg:cli-test applies to `@slack/cli-test` labels Mar 3, 2026
@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2026

🦋 Changeset detected

Latest commit: 76e02e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@slack/logger Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (dbd38e2) to head (76e02e3).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2531   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files          82       82           
  Lines       14980    14980           
  Branches      508      508           
=======================================
  Hits        13582    13582           
  Misses       1373     1373           
  Partials       25       25           
Flag Coverage Δ
cli-hooks 90.66% <ø> (ø)
cli-test 90.66% <ø> (ø)
logger 90.66% <ø> (ø)
oauth 90.66% <ø> (ø)
socket-mode 90.66% <ø> (ø)
web-api 90.66% <ø> (ø)
webhook 90.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:typescript issues that specifically impact using the package from typescript projects pkg:cli-hooks applies to `@slack/cli-hooks` pkg:cli-test applies to `@slack/cli-test` pkg:logger applies to `@slack/logger` pkg:oauth applies to `@slack/oauth` pkg:rtm-api applies to `@slack/rtm-api` pkg:socket-mode applies to `@slack/socket-mode` pkg:types applies to `@slack/types` pkg:web-api applies to `@slack/web-api` pkg:webhook applies to `@slack/webhook` semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant