Skip to content

build: use a shared tsconfig for workspace packages#2532

Open
zimeg wants to merge 2 commits intotypes18from
tsconfig
Open

build: use a shared tsconfig for workspace packages#2532
zimeg wants to merge 2 commits intotypes18from
tsconfig

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Mar 3, 2026

Summary

This PR uses a shared tsconfig across packages for #1941. This removes shared development dependencies from specific packages!

Requirements

@zimeg zimeg self-assigned this Mar 3, 2026
@zimeg zimeg requested a review from a team as a code owner March 3, 2026 22:43
@zimeg zimeg added semver:patch tests M-T: Testing work only area:typescript issues that specifically impact using the package from typescript projects pkg:web-api applies to `@slack/web-api` pkg:rtm-api applies to `@slack/rtm-api` pkg:webhook applies to `@slack/webhook` pkg:logger applies to `@slack/logger` pkg:types applies to `@slack/types` pkg:oauth applies to `@slack/oauth` pkg:socket-mode applies to `@slack/socket-mode` pkg:cli-hooks applies to `@slack/cli-hooks` pkg:cli-test applies to `@slack/cli-test` labels Mar 3, 2026
@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: cc3bfc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zimeg zimeg linked an issue Mar 3, 2026 that may be closed by this pull request
monorepo: upgrade to TS 5.5, consider using ${configDir} to DRY up tsconfig.json #1941
Open
@codecov
Copy link

codecov bot commented Mar 3, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (76e02e3) to head (cc3bfc1).
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff            @@
##           types18    #2532   +/-   ##
========================================
  Coverage    90.66%   90.66%           
========================================
  Files           82       82           
  Lines        14980    14980           
  Branches       508      508           
========================================
  Hits         13582    13582           
  Misses        1373     1373           
  Partials        25       25
Flag Coverage Δ
cli-hooks 90.66% <ø> (ø)
cli-test 90.66% <ø> (ø)
logger 90.66% <ø> (ø)
oauth 90.66% <ø> (ø)
socket-mode 90.66% <ø> (ø)
web-api 90.66% <ø> (ø)
webhook 90.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zimeg
zimeg commented Mar 3, 2026
View reviewed changes
Copy link
Member Author

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💌 A note for kind reviewers toward the health of the project!

packages/oauth/tsconfig.json
{
"$schema": "https://json.schemastore.org/tsconfig",
"compilerOptions": {
"target": "es5",
Copy link
Member Author

@zimeg zimeg Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📣 note: Since we support a minimum node18 which supports es2022 this changes seems alright to me, but I want to note this will now match the shared es2017 target.

@zimeg
Copy link
Member Author

zimeg commented Mar 3, 2026

📚 Toward #2359 as well!

WilliamBergamin
WilliamBergamin approved these changes Mar 4, 2026
View reviewed changes
Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sweet changes 💯

packages/cli-hooks/jsconfig.json
@@ -1,24 +1,9 @@
{
"$schema": "https://json.schemastore.org/jsconfig",
Copy link
Contributor

@WilliamBergamin WilliamBergamin Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 💯

packages/webhook/tsconfig.json
// to use import instead of require(), but it's not worth the tradeoff of restructuring the build (for now).
// "resolveJsonModule": true,
},
"extends": "../../tsconfig.base.json",
Copy link
Contributor

@WilliamBergamin WilliamBergamin Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WilliamBergamin WilliamBergamin WilliamBergamin approved these changes

Assignees

@zimeg zimeg

Labels

area:typescript issues that specifically impact using the package from typescript projects pkg:cli-hooks applies to `@slack/cli-hooks` pkg:cli-test applies to `@slack/cli-test` pkg:logger applies to `@slack/logger` pkg:oauth applies to `@slack/oauth` pkg:rtm-api applies to `@slack/rtm-api` pkg:socket-mode applies to `@slack/socket-mode` pkg:types applies to `@slack/types` pkg:web-api applies to `@slack/web-api` pkg:webhook applies to `@slack/webhook` semver:patch tests M-T: Testing work only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

monorepo: upgrade to TS 5.5, consider using ${configDir} to DRY up tsconfig.json

2 participants

@zimeg @WilliamBergamin