fix: nitroV2Plugin compress public assets by default#2112
Open
yinonburgansky wants to merge 1 commit intosolidjs:mainfrom
Open
fix: nitroV2Plugin compress public assets by default#2112yinonburgansky wants to merge 1 commit intosolidjs:mainfrom
yinonburgansky wants to merge 1 commit intosolidjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 0a4b697 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
fixes solidjs#2096 - match `1.x` behavior for easier migration; can still be overridden to false for users who prefer uncompressed files. - extract common build test utilities. - fix tree shaking tests that were using unreliable regex (didn't account for minification and variable renaming); replace with a unique string identifier for better resilience, and add a complementary test for the tree shaking with side effects case. - add vitest `~` alias configuration, as the solid plugin wasn't resolving it in the test environment.
yinonburgansky
force-pushed
the
compress-assets
branch
from
b466fac to
0a4b697
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Changes
1.xbehavior for easier migration; can still be overridden to false for users who prefer uncompressed files.~alias configuration, as the solid plugin wasn't resolving it in the test environment.