Fix Cloudflare preset not generating functioning applications#2116
Open
dario-piotrowicz wants to merge 1 commit intosolidjs:mainfrom
Open
Fix Cloudflare preset not generating functioning applications#2116dario-piotrowicz wants to merge 1 commit intosolidjs:mainfrom
dario-piotrowicz wants to merge 1 commit intosolidjs:mainfrom
Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: a17ec8b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
nitroV2Plugindoesn't generate a valid output with Cloudflare presets #2115👆 No, I don't think that there are tests for the plugin package, if I'm wrong and some tests should be added please do let me know 🙂
What is the current behavior?
Setting up a Cloudflare preset in the plugin's configuration object results in builds not producing a functioning result (see #2115)
What is the new behavior?
A Cloudflare preset can be passed to the plugin's configuration object and builds do produce functioning applications.
Other information
To manually test the changes, create a solid start app via
npm create solid, apply one of the cloudflare presets, runnpm run buildfollows by thewrangler devcommand that the build command presents in its output and see that the resulting application does not render. Try again but using this PRs pkg-pr-new and see that now it works as intended.Note: I only tested the changes with
cloudflare-modulesince, as far as I know, it's the generally preferred preset for Cloudflare deployments